fix: permissions on /var/log/amazon directory #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natmatn
reviewed
Feb 16, 2024
Problem: It's been reported that when the worker-agent installer, running as root, creates `/var/log/amazon/deadline` that the agent was unable to write its own logs to that directory when running as a non-root user. Solution: Add go+rx to `/var/log/amazon` -- this is the solution reported to work by the reporting customer. Signed-off-by: Daniel Neilson <53624638+ddneilson@users.noreply.github.com>
ddneilson
force-pushed
the
ddneilson/21264
branch
from
9798084
to
e0287fe
Compare
epmog
approved these changes
Feb 20, 2024
gmchale79
approved these changes
Feb 20, 2024
This was referenced Feb 22, 2024
Closed
Merged
Merged
gmchale79
pushed a commit
that referenced
this pull request
Mar 11, 2024
Problem: It's been reported that when the worker-agent installer, running as root, creates `/var/log/amazon/deadline` that the agent was unable to write its own logs to that directory when running as a non-root user. Solution: Add go+rx to `/var/log/amazon` -- this is the solution reported to work by the reporting customer. Signed-off-by: Daniel Neilson <53624638+ddneilson@users.noreply.github.com> Signed-off-by: Graeme McHale <gmchale@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
It's been reported that when the worker-agent installer, running as root, creates
/var/log/amazon/deadlinethat the agent was unable to write its own logs to that directory when running as a non-root user.What was the solution? (How)
Add go+rx to
/var/log/amazon-- this is the solution reported to work by the reporting customer.What is the impact of this change?
The installer should be closer to working as-is without hacks.
How was this change tested?
It's a straightforward application of the solution found by the customer. We don't currently have direct tests for the installer, unfortunately.
Was this change documented?
N/A
Is this a breaking change?
No