-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: report action timeout as failed with timeout message #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddneilson
force-pushed
the
ddneilson/19468
branch
from
February 21, 2024 20:43
0da8d7c
to
80f50de
Compare
gmchale79
previously approved these changes
Feb 21, 2024
jericht
previously approved these changes
Feb 21, 2024
mwiebe
requested changes
Feb 21, 2024
ddneilson
force-pushed
the
ddneilson/19468
branch
from
February 21, 2024 21:14
80f50de
to
c526c6f
Compare
mwiebe
previously approved these changes
Feb 21, 2024
jericht
previously approved these changes
Feb 21, 2024
gmchale79
previously approved these changes
Feb 21, 2024
Problem: Previously, if an OpenJD Action was canceled due to a timeout being reached then we'd report the action as just canceled. The change to update to openjd-sessions 0.5.0 ( #160 ) made it so that timeout actions would report as FAILED, but didn't change the failure message to make it clear that the reason for the failure was a timeout. Solution: We mutate the action status when we recieve it to override the failure message with one that indicates that the action has reached its runtime limit. Signed-off-by: Daniel Neilson <53624638+ddneilson@users.noreply.github.com>
ddneilson
force-pushed
the
ddneilson/19468
branch
from
February 21, 2024 22:58
c526c6f
to
4cc3f90
Compare
mwiebe
approved these changes
Feb 21, 2024
jericht
approved these changes
Feb 21, 2024
This was referenced Feb 22, 2024
Closed
Merged
Merged
gmchale79
pushed a commit
that referenced
this pull request
Mar 11, 2024
Problem: Previously, if an OpenJD Action was canceled due to a timeout being reached then we'd report the action as just canceled. The change to update to openjd-sessions 0.5.0 ( #160 ) made it so that timeout actions would report as FAILED, but didn't change the failure message to make it clear that the reason for the failure was a timeout. Solution: We mutate the action status when we recieve it to override the failure message with one that indicates that the action has reached its runtime limit. Signed-off-by: Daniel Neilson <53624638+ddneilson@users.noreply.github.com> Signed-off-by: Graeme McHale <gmchale@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
Previously, if an OpenJD Action was canceled due to a timeout being reached then we'd report the action as just canceled. The change to update to openjd-sessions 0.5.0 ( #160 ) made it so that timeout actions would report as FAILED, but didn't change the failure message to make it clear that the reason for the failure was a timeout.
What was the solution? (How)
We mutate the action status when we recieve it to override the failure message with one that indicates that the action has reached its runtime limit.
What is the impact of this change?
The customer should have an easier time of identifying which tasks/actions failed due to a timeout rather than having just been canceled for some other reason.
How was this change tested?
I updated a unit test, and also ran the agent against the service with a sleep job that has a runtime limit. Here's a snapshot of one of the session actions that results:
Was this change documented?
N/A
Is this a breaking change?
No