[Job Attachments] Add Hash Alg File Extensions to Objects Uploaded to CAS #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marofke
force-pushed
the
marofke/ja-add-upload-file-ext
branch
from
8d8c0ce
to
b4d3c27
Compare
marofke
force-pushed
the
marofke/ja-add-upload-file-ext
branch
from
b4d3c27
to
4dbf60a
Compare
Signed-off-by: Caden Marofke <marofke@amazon.com>
marofke
force-pushed
the
marofke/ja-add-upload-file-ext
branch
from
4dbf60a
to
4a63a38
Compare
marofke
changed the title
natmatn
approved these changes
Feb 29, 2024
mwiebe
approved these changes
Feb 29, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
We need to revert #166 once sufficient time has passed from release
What was the solution? (How)
Revert the changes from #166
What is the impact of this change?
Files uploaded to the Job Attachments bucket now use a file extension marking which hashing algorithm was used. Manifests uploaded do not use the hashing algorithm as it is not needed.
How was this change tested?
Was this change documented?
N/A
Is this a breaking change?
Yes