Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(job_attachments)!: rename OperatingSystemFamily to StorageProfileOperatingSystemFamily #192

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

gahyusuh
Copy link
Contributor

@gahyusuh gahyusuh commented Feb 29, 2024

What was the problem/requirement? (What/Why)

The class named OperatingSystemFamily, used for specifying the OS family of StorageProfile, had a name that was too generic.

What was the solution? (How)

The OperatingSystemFamily Enum class was renamed to StorageProfileOperatingSystemFamily to provide clearer context within the StorageProfile.

What is the impact of this change?

Makes it clearer what the enum pertains to.

How was this change tested?

  • Ran both unit tests and integ tests to ensure everything passed successfully.
  • Verified that job submissions to the Farm/Queue that has Storage Profiles (for both Linux and Windows), and output downloads work correctly without any failures.

Was this change documented?

No.

Is this a breaking change?

This class doesn't seem to be used in any other packages (such as deadline-cloud-worker-agent and deadline-cloud-* packages) other than this one, but since the class name was changed, I think this change could be a breaking change.

…ofileOperatingSystemFamily

Signed-off-by: Gahyun Suh <132245153+gahyusuh@users.noreply.github.com>
@gahyusuh gahyusuh force-pushed the gahyusuh/rename_osfamily_class branch from 1e3a2ad to 886c9cc Compare February 29, 2024 15:16
@gahyusuh gahyusuh marked this pull request as ready for review February 29, 2024 15:26
@gahyusuh gahyusuh requested a review from a team as a code owner February 29, 2024 15:26
@gahyusuh gahyusuh merged commit 7743ad8 into mainline Feb 29, 2024
18 checks passed
@gahyusuh gahyusuh deleted the gahyusuh/rename_osfamily_class branch February 29, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants