fix(ui): resource listing ignores case #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucaseck
changed the title
lucaseck
force-pushed
the
lucaseck/case_insensitive_sorting
branch
from
11fa6b7
to
ccb05bd
Compare
epmog
approved these changes
Mar 4, 2024
lucaseck
changed the title
Signed-off-by: Lucas Eckhardt <117225985+lucaseck@users.noreply.github.com>
lucaseck
force-pushed
the
lucaseck/case_insensitive_sorting
branch
from
ccb05bd
to
3f7f8c5
Compare
erico-aws
approved these changes
Mar 5, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
When viewing the resource lists in the UI settings they were sorted alphabetically, but case sensitive with uppercase taking priority over lowercase.
e.g. With 3 farms
afarm,Bfarm,cfarmthe order would be:What was the solution? (How)
Added casefold to the display name sort key.
What is the impact of this change?
The example above is now sorted
-afarm
-Bfarm
-cfarm
How was this change tested?
Manually viewing the farm, queue and storage profiles before and after
Was this change documented?
No
Is this a breaking change?
No, this is only a UI change