feat: keep standalone gui open after submission #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucaseck
force-pushed
the
lucaseck/keep-gui-open
branch
from
617fe49
to
62868c8
Compare
ttblanchard
approved these changes
Mar 7, 2024
erico-aws
approved these changes
Mar 7, 2024
Signed-off-by: lucaseck <117225985+lucaseck@users.noreply.github.com>
epmog
force-pushed
the
lucaseck/keep-gui-open
branch
from
62868c8
to
0438ed4
Compare
Merged
npmacl
pushed a commit
that referenced
this pull request
Mar 21, 2024
Signed-off-by: lucaseck <117225985+lucaseck@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
The standalone gui to submit from closes after each submission. This makes it hard to iterate and submit multiple jobs while varying the parameters for a job bundle without having to reopen each time.
What was the solution? (How)
Added a check to only close the submission dialog if the submitter is not the standalone "JobBundle" submitter.
What is the impact of this change?
How was this change tested?
Was this change documented?
No
Is this a breaking change?
Shouldn't be