refactor!: rename creds -> auth, credentials -> authentication #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS-Samuel
force-pushed
the
samuel/creds_auth_rename
branch
9 times, most recently
from
d2dcf0f
to
cc510f7
Compare
- rename cli "creds" option to "auth"
former: "deadline creds login/logout/status"
new: "deadline auth login/logout/status"
- rename:
"DeadlineCredentialsStatus" -> "DeadlineAuthenticationStatus"
"DeadlineCredentialsStatusWidget" ->"DeadlineAuthenticationStatusWidget"
"AwsCredentialsType" -> "AwsCredentialsSource"
"AwsCredentialsStatus" -> "AwsAuthenticationStatus"
Signed-off-by: Samuel Anderson <119458760+AWS-Samuel@users.noreply.github.com>
AWS-Samuel
force-pushed
the
samuel/creds_auth_rename
branch
from
cc510f7
to
7836612
Compare
epmog
approved these changes
Mar 7, 2024
Comment on lines
+109
to
+111
| kwargs["credentials_source"] | ||
| == AwsCredentialsSource.DEADLINE_CLOUD_MONITOR_LOGIN | ||
| ): |
There was a problem hiding this comment.
That's how black formatted it?! Interesting...
ddneilson
approved these changes
Mar 7, 2024
Merged
npmacl
pushed a commit
that referenced
this pull request
Mar 21, 2024
- rename cli "creds" option to "auth"
former: "deadline creds login/logout/status"
new: "deadline auth login/logout/status"
- rename:
"DeadlineCredentialsStatus" -> "DeadlineAuthenticationStatus"
"DeadlineCredentialsStatusWidget" ->"DeadlineAuthenticationStatusWidget"
"AwsCredentialsType" -> "AwsCredentialsSource"
"AwsCredentialsStatus" -> "AwsAuthenticationStatus"
**BREAKING CHANGE**
The `deadline creds` subcommand has been renamed to `deadline auth`
Signed-off-by: Samuel Anderson <119458760+AWS-Samuel@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
An offline discussion resulted in a preference to using
authovercredsfor login/logout workflows.What was the solution? (How)
Rename
credscli command toauth(breaking)Also looked at a few of our APIs/public classes and renamed where it felt it made sense, most "credential" type/status were referring to if the user was authenticated to the service.
What is the impact of this change?
Big breaking change:
Hopefully nicer name.
How was this change tested?
hatch run testRan CLI, confirmed it worked as expected
Ran GUI, confirmed it worked as expected
Was this change documented?
Not really, but will be in the change log.
Is this a breaking change?
YES