fix(job_attachments): improvements to nonvalid error messages #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gahyusuh
force-pushed
the
gahyusuh/fix_flakey_tests
branch
from
cb13ad1
to
0ce2514
Compare
jericht
approved these changes
Mar 7, 2024
jusiskin
approved these changes
Mar 7, 2024
|
@gahyusuh: the commit/PR title is used to generate the changelog. Can we adjust the message to reflect the functional changes? |
gahyusuh
changed the title
gahyusuh
changed the title
Fixed a flakey unit test for handling nonvalid config settings. Signed-off-by: Gahyun Suh <132245153+gahyusuh@users.noreply.github.com>
gahyusuh
force-pushed
the
gahyusuh/fix_flakey_tests
branch
from
0ce2514
to
20f10de
Compare
gahyusuh
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
We noticed a flaky unit test in the job attachments part of the package: https://github.com/casillas2/deadline-cloud/actions/runs/8165059251/job/22321551354
The reason it was flakey is because (I think) it sometimes throw this AssetSyncError, and sometimes it throws this AssetSyncError from different place, and the former includes the phrase “Invalid value for configuration setting: ” in the error message, but the latter does not. So it can fail in the assert that checks if the phrase is included in the error message.
What was the solution? (How)
get_s3_max_pool_connections().What is the impact of this change?
The tests should be less flaky.
How was this change tested?
Ran
hatch run lint && hatch run testand made sure all passed.Was this change documented?
No.
Is this a breaking change?
No.