fix: clear storage profiles in gui submitter #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Trevor Blanchard <blantrev@amazon.com>
ttblanchard
force-pushed
the
clear-storage-profile-config
branch
from
62aa427
to
a30a988
Compare
epmog
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
Chatted offline, Since Storage Profiles are at the farm-level, this fix (allowing a user to easily swap between queues that do or do not have their storage profile) will introduce a slight UX negative, in that if they switch to a queue without their storage profile allowed and apply the settings, then it won't remember their storage profile for the queues that do support it.
In practice, this should be rare, but it's very easy to hit with testing. We'll have to revisit this when we have more time to polish that experience.
Ship it!
lucaseck
approved these changes
Mar 12, 2024
Merged
npmacl
pushed a commit
that referenced
this pull request
Mar 21, 2024
Signed-off-by: Trevor Blanchard <blantrev@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
In the Gui Config, when changing the default Queue if the selected Queue does not have the select default Storage Profile in it's list of Allowed Storage Profiles the Storage Profile is not cleared from the config file.
What was the solution? (How)
Always check the value of the Storage Profile control when saving the config to disk.
What is the impact of this change?
When a default Queue is selected that doesn't have the selected default Storage Profile in it's list of Allowed Storage Profiles, the value is cleared from the config when saved.
How was this change tested?
Launched the UI with 2 Queues and 1 Storage Profile configured:
Queue1 - Allowed SP 1
Queue2 - No SP
Was this change documented?
No
Is this a breaking change?
No