fix: Mock STS calls for some JA upload tests #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Caden Marofke <marofke@amazon.com>
marofke
force-pushed
the
marofke/fix-sts-unit-tests
branch
from
078bb41
to
6a043ff
Compare
epmog
approved these changes
Mar 22, 2024
moorec-aws
approved these changes
Mar 22, 2024
Merged
baxeaz
pushed a commit
that referenced
this pull request
Mar 23, 2024
Signed-off-by: Caden Marofke <marofke@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
Some unit tests were failing to pass since we weren't mocking the STS calls.
What was the solution? (How)
Add the
@mockstsattribute to the missed unit tests.What is the impact of this change?
Tests pass.
How was this change tested?
Ran unit tests from mainline, confirmed they failed. With these changes, confirmed they passed.
Was this change documented?
N/A
Is this a breaking change?
Unbreaking