feat!: VFS Logs under sessionfolder/.vfs_logs #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er at sessiondir/.vfs_log Signed-off-by: Brian Axelson <baxelson@amazon.com>
Signed-off-by: Brian Axelson <baxelson@amazon.com>
npmacl
approved these changes
Mar 28, 2024
baxeaz
changed the title
…e can have at least some windows code coverage, even though the VFS itself doesn't yet work on windows. Signed-off-by: Brian Axelson <baxelson@amazon.com>
ddneilson
approved these changes
Mar 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
The VFS logs were written to a folder which persisted after the session was complete. They need to be written to the session folder and be cleaned after each session.
What was the solution? (How)
Move the cwd of the vfs to the session folder.
What is the impact of this change?
Logs should be output to sessiondir/.vfs_logs and be cleaned with the rest of the session data.
How was this change tested?
New tests added, all tests pass. Installed on a new CMF worker instance, ran jobs, observed logs written to session directory rather than old logs folder.
Was this change documented?
No
Is this a breaking change?
No