fix: only load queue environments when connected to a queue #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS-Samuel
force-pushed
the
samuel/queue_env_fix
branch
from
9515e46
to
85b5036
Compare
Signed-off-by: Samuel Anderson <119458760+AWS-Samuel@users.noreply.github.com>
AWS-Samuel
force-pushed
the
samuel/queue_env_fix
branch
from
85b5036
to
9cc8e2e
Compare
lucaseck
approved these changes
Mar 29, 2024
marofke
approved these changes
Mar 29, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
Previously, on the first time loading a submitter without the farm/queue set, users would get an error like:
The error makes it sound like an issue with the IAM role but it's actually an issue with the resource we're trying to access, which does not exist (malformed ARN)
What was the solution? (How)
Check if we have a queue and farm before looking for queue environments
What is the impact of this change?
Less errors!
How was this change tested?
Tested within a DCC context and confirmed the error went away, and that once I selected a farm and queue, the queue environment field was populated
Was this change documented?
What does this question mean?
Is this a breaking change?
No!