fix: only hookup stdin on windows for dcm login #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Samuel Anderson <119458760+AWS-Samuel@users.noreply.github.com>
AWS-Samuel
force-pushed
the
samuel/login_change
branch
from
a098a21
to
d42c241
Compare
epmog
approved these changes
Mar 31, 2024
prestomation
approved these changes
Mar 31, 2024
jusiskin
approved these changes
Mar 31, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
For the login flow, we were hooking into
stdinon all systems due to a windows specific behavior. This puts us at risk of receiving aSIGTTINon Linux even though we don't need to read fromstdinwhen launching in aTTYWhat was the solution? (How)
Only hook into
stdinon Windows operating systems.What is the impact of this change?
Login is more robust on non-windows systems
How was this change tested?
Tested on a RHEL 9 instance and observed that the login/logout flows could be completed successfully with this change
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.