fix: set QT_API to pyside6 or pyside2 for deadline-cli #284
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
If a user has PyQt5/6 installed in their environment, launching the gui from the deadline client cli will throw an error saying
TypeError: 'f' is an unknown keyword argument
. This is because PyQt5/6 does not define f as a keyword arg in the QDialog constructor, even though Qt, PySide2, and PySide6 do.This error will occur even if PySide6 or PySide2 are in the environment.
What was the solution? (How)
For now, set the QT_API environment variable to use/prioritize our supported Qt bindings.
ref: https://github.com/spyder-ide/qtpy/tree/master?tab=readme-ov-file#requirements
Can always add PyQt5/6 support in the future if needed.
What is the impact of this change?
Users with additional dependencies in their environment will continue to work!
How was this change tested?
Before the fix:
received this error, since
f
is not a keyword for a QDialog in PyQt5/6After fix without changing environment:
And the gui launched properly
Was this change documented?
N/A
Is this a breaking change?
Nope
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.