Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(job_attachments): fix integration test exception #298

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

chocecil
Copy link
Contributor

What was the problem/requirement? (What/Why)

Integration test failure in test_upload_bucket_wrong_account

E           deadline.job_attachments.exceptions.JobAttachmentsS3ClientError: Error uploading binary file in bucket 'job-attachment-bucket-snipe-test', Target key or prefix: 'root/Manifests/farm-f04d68d177184646ad0d527964e6f9ba/queue-3495b8b2f71a40c09f0d72267805ab86/Inputs/10ca0ac8feb34af999e13bc0e0715e7f/92b571571820100103aedfc230a145c8_input', HTTP Status Code: 403, Forbidden or Access denied. Please check your AWS credentials, and ensure that your AWS IAM Role or User has the 's3:PutObject' permission for this bucket.  An error occurred (AccessDenied) when calling the PutObject operation: Access Denied

/home/chocecil/.local/share/mise/installs/python/latest/lib/python3.12/site-packages/deadline/job_attachments/upload.py:645: JobAttachmentsS3ClientError

What was the solution? (How)

changed the exception type and message

What is the impact of this change?

Integ tests pass, no logic changes

How was this change tested?

hatch run integ:test

Was this change documented?

Is this a breaking change?

No

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@chocecil chocecil requested a review from marofke April 12, 2024 23:38
@chocecil chocecil marked this pull request as ready for review April 13, 2024 00:07
@chocecil chocecil requested a review from a team as a code owner April 13, 2024 00:07
Copy link
Contributor

@leongdl leongdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering - how did this exception change? What code led to this change?

Copy link
Contributor

@jericht jericht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: Cecilia Cho <chocecil@amazon.com>
@chocecil chocecil merged commit 3c700b0 into aws-deadline:mainline Apr 15, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants