Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove deprecated .aws/sso/cache watcher #322

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

epmog
Copy link
Contributor

@epmog epmog commented Apr 29, 2024

What was the problem/requirement? (What/Why)

closes #316

We were watching a folder we no longer care about and due to this, we were emitting an message that made users believe there was something critically wrong with their setup.

What was the solution? (How)

As suggested in the issue, remove the watcher line! There are no other references to this path elsewhere in the code base.

What is the impact of this change?

No more misleading error messages around the sso/cache folder.

How was this change tested?

hatch run fmt
hatch build
hatch run lint
hatch run test

Was this change documented?

N/A

Is this a breaking change?

Nope


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Signed-off-by: Morgan Epp <60796713+epmog@users.noreply.github.com>
@epmog epmog requested a review from a team as a code owner April 29, 2024 22:32
@epmog epmog added the bug Something isn't working label Apr 29, 2024
@epmog epmog merged commit 72d6c26 into aws-deadline:mainline Apr 29, 2024
15 checks passed
@epmog epmog deleted the remove_sso_cache branch April 29, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Misleading error message regarding setting up a file watch on ~/.aws/sso/cache
3 participants