Install boto3 CRT extra feature always #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Crowe <crowest@amazon.com>
crowecawcaw
force-pushed
the
crt-dependency
branch
from
94063f2
to
3807863
Compare
YutongLi291
approved these changes
May 9, 2024
epmog
approved these changes
May 9, 2024
Merged
leongdl
added a commit
to leongdl/deadline-cloud
that referenced
this pull request
May 27, 2024
This reverts commit dffc71e. Revert "feat: use AWS CRT for faster transfers (aws-deadline#319)" This reverts commit 52da0ea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
When I added boto3 CRT support, I installed different versions of boto3 depending on of the underlying CRT libraries were available for the current version of Python. This prevent some unit tests from running in non-CRT enabled Python versions (namely 3.12). Also boto3 already handles CRT-Python compatibility, so we don't need to and shouldn't try to manage it ourselves.
What was the solution? (How)
Remove the Python version filters on the CRT extra feature. Let boto3 handle compatibility and fallbacks.
What is the impact of this change?
Package builds in Python 3.12.
How was this change tested?
Using Python 3.12, I ran the unit tests, installed the package, and uploaded some job attachments using the CLI. Tests pass and uploads work as expected (though slower because they aren't using CRT under the hood).
Was this change documented?
No need.
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.