fix: bundle submit parameter processing splits name/value at right-most = #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Also incorporated a regex for the Open Job Description identifier constraints, to fail parameter validation when parameter names do not conform. * Added two tests, one for the '=' splitting and one for the parameter name validation. Signed-off-by: Mark Wiebe <399551+mwiebe@users.noreply.github.com>
mwiebe
force-pushed
the
fix-job-param-split
branch
from
165b730
to
5f375b4
Compare
epmog
approved these changes
May 13, 2024
jusiskin
approved these changes
May 14, 2024
mwiebe
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
When providing parameter values for a parameter like
CondaPackages, it often has an=in it like-p CondaPackages=blender=3.6. The regex validating these parameters allows the=to get in the parameter nameinstead of the parameter value. The parameter name further needs to conform to the Open Job Description
syntax, so it would be helpful to validate it against that.
What was the solution? (How)
What is the impact of this change?
Submitting jobs from the CLI for the buggy case will work. Other cases where the parameter name
doesn't conform will produce a quicker and more clear error message.
How was this change tested?
Added unit tests, submitted a job and confirmed the parameter value was set correctly.
Was this change documented?
No
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.