fix: use sids when granting permissions with icacls #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charles Moore <moorec@amazon.com>
moorec-aws
force-pushed
the
moorec/add-sid
branch
from
02f6579
to
ae098ba
Compare
ddneilson
reviewed
Jun 19, 2024
ddneilson
approved these changes
Jun 20, 2024
AWS-Samuel
approved these changes
Jun 20, 2024
Merged
rena-cheng
pushed a commit
to rena-cheng/deadline-cloud
that referenced
this pull request
Jun 26, 2024
Signed-off-by: Charles Moore <122481442+moorec-aws@users.noreply.github.com> Signed-off-by: Cloud User <rocky@ip-172-31-31-216.ec2.internal>
rena-cheng
pushed a commit
to rena-cheng/deadline-cloud
that referenced
this pull request
Jun 26, 2024
Signed-off-by: Charles Moore <122481442+moorec-aws@users.noreply.github.com> Signed-off-by: Cloud User <rocky@ip-172-31-31-216.ec2.internal>
rena-cheng
pushed a commit
to rena-cheng/deadline-cloud
that referenced
this pull request
Jun 26, 2024
…deadline#344) * fix: bundles are stored in job_history in their original format Signed-off-by: Stephen Crowe <crowest@amazon.com> fix: use sids when granting permissions with icacls (aws-deadline#359) Signed-off-by: Charles Moore <122481442+moorec-aws@users.noreply.github.com> Signed-off-by: Cloud User <rocky@ip-172-31-31-216.ec2.internal> chore: Add OS field support for integ test (aws-deadline#361) Signed-off-by: Alex Tran <167144297+AlexTranAmz@users.noreply.github.com> Signed-off-by: Cloud User <rocky@ip-172-31-31-216.ec2.internal> fix: bundle gui-submit fails loading bundles with saved queue parameter values (aws-deadline#360) Signed-off-by: Evan Spearman <evans@amazon.com> Signed-off-by: Cloud User <rocky@ip-172-31-31-216.ec2.internal> ci: update workflow job names for integ tests (aws-deadline#338) Signed-off-by: Charles Moore <122481442+moorec-aws@users.noreply.github.com> Signed-off-by: Cloud User <rocky@ip-172-31-31-216.ec2.internal> Squish Automated Tests - Settings flow for Dev Submit GUI Change env var to relative path Squish Automated Tests - Dev Submit GUI Settings Flow Squish Automated Tests - Dev Submit GUI settings flow Signed-off-by: Cloud User <rocky@ip-172-31-31-216.ec2.internal> ci: Add integ req to toml (aws-deadline#364) Signed-off-by: Alex Tran <167144297+AlexTranAmz@users.noreply.github.com> Signed-off-by: Cloud User <rocky@ip-172-31-31-216.ec2.internal> Fixing linting errors Signed-off-by: Cloud User <rocky@ip-172-31-31-216.ec2.internal> feat: support JSON output in bundle GUI submitter (aws-deadline#357) * feat: support JSON output in bundle GUI submitter Signed-off-by: Stephen Crowe <crowest@amazon.com> Signed-off-by: Cloud User <rocky@ip-172-31-31-216.ec2.internal> fixing formatting/lint issues Signed-off-by: Cloud User <rocky@ip-172-31-31-216.ec2.internal> fixing linting issues Signed-off-by: Cloud User <rocky@ip-172-31-31-216.ec2.internal> fixing linting errors Signed-off-by: Cloud User <rocky@ip-172-31-31-216.ec2.internal> chore(release): 0.48.5 (aws-deadline#367) Signed-off-by: client-software-ci <129794699+client-software-ci@users.noreply.github.com> Signed-off-by: Cloud User <rocky@ip-172-31-31-216.ec2.internal> chore(deps): update python-semantic-release requirement (aws-deadline#342) Updates the requirements on [python-semantic-release](https://github.com/python-semantic-release/python-semantic-release) to permit the latest version. - [Release notes](https://github.com/python-semantic-release/python-semantic-release/releases) - [Changelog](https://github.com/python-semantic-release/python-semantic-release/blob/master/CHANGELOG.md) - [Commits](python-semantic-release/python-semantic-release@v9.5.0...v9.8.1) --- updated-dependencies: - dependency-name: python-semantic-release dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Cloud User <rocky@ip-172-31-31-216.ec2.internal> Disabling lint error checks due to Squish modules Signed-off-by: Cloud User <rocky@ip-172-31-31-216.ec2.internal> feat: Adding automated tests using Squish framework: Dev Submit GUI Settings flow Signed-off-by: Cloud User <rocky@ip-172-31-31-216.ec2.internal> feat: Adding automated tests using Squish framework: Dev Submit GUI Settings flow Signed-off-by: Cloud User <rocky@ip-172-31-31-216.ec2.internal>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
icacls will fail to set permissions on the config directory when using non-english operating systems.
What was the solution? (How)
Use the SID of Administrators and SYSTEM to set the permissions. with icacls.
What is the impact of this change?
Users using different OS languages can use the submitter.
How was this change tested?
Tested on a Windows OS with Spanish setup. Confirmed I was not able to submit a blender job to a farm. Once the change was implemented, job submission was successful.
Was this change documented?
No
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.