feat: support JSON output from bundle gui-submit #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucaseck
approved these changes
Jun 28, 2024
epmog
reviewed
Jun 28, 2024
crowecawcaw
approved these changes
Jul 2, 2024
Signed-off-by: Joel Wong <127782171+joel-wong-aws@users.noreply.github.com>
epmog
approved these changes
Jul 2, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied from #357
This is a simplified version of that PR.
What was the problem/requirement? (What/Why)
In a DCC integration, I was trying to read out the most recently submitted job settings. The bundle GUI submitter prints a human readable output with the bundle directory path where the settings can be found. but the response is not machine readable.
What was the solution? (How)
Add a JSON output option.
What is the impact of this change?
Scripts calling the GUI submitter can easily read back where the job bundle is saved and what the submitted job ID is.
How was this change tested?
Unit tests and manually running the CLI commands.
Was this change documented?
Auto-documented in the CLI help.
Is this a breaking change?
No - new minor feature.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.