Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Add an 'operation' argument to the job bundle export callback. #92

Merged
merged 1 commit into from
Nov 8, 2023
Merged

feat!: Add an 'operation' argument to the job bundle export callback. #92

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions src/deadline/client/ui/dialogs/submit_job_to_deadline_dialog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
from ..widgets.host_requirements_tab import HostRequirementsWidget
from . import DeadlineConfigDialog, DeadlineLoginDialog
from ...job_bundle.submission import AssetReferences
from ._types import JobBundlePurpose

logger = logging.getLogger(__name__)

Expand Down Expand Up @@ -350,11 +351,17 @@ def on_export_bundle(self):
queue_parameters,
asset_references,
requirements,
purpose=JobBundlePurpose.EXPORT,
)
else:
# Maintaining backward compatibility for submitters that do not support host_requirements yet
self.on_create_job_bundle_callback(
self, job_history_bundle_dir, settings, queue_parameters, asset_references
self,
job_history_bundle_dir,
settings,
queue_parameters,
asset_references,
purpose=JobBundlePurpose.EXPORT,
)

logger.info(f"Saved the submission as a job bundle: {job_history_bundle_dir}")
Expand Down Expand Up @@ -407,11 +414,17 @@ def on_submit(self):
queue_parameters,
asset_references,
requirements,
purpose=JobBundlePurpose.SUBMISSION,
)
else:
# Maintaining backward compatibility for submitters that do not support host_requirements yet
self.on_create_job_bundle_callback(
self, job_history_bundle_dir, settings, queue_parameters, asset_references
self,
job_history_bundle_dir,
settings,
queue_parameters,
asset_references,
purpose=JobBundlePurpose.SUBMISSION,
)

farm_id = get_setting("defaults.farm_id")
Expand Down