Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor deployment handler #762

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sameerzuberi
Copy link
Member

Issue #, if available:

Description of changes:
Significant refactor of deployment_handler

  • Removed configuration logic from deployment handler and condensed it in deployment_configuration. We now have two generic helper functions to read Nucleus and system configs and one helper function to retrieve the posix user (this is because the posix user is under an additional nested key)
  • Removed dependency resolution logic from deployment handler and created dependency_resolver. Also refactored dependency resolution in the process to reduce repeated code and improve readability.
  • Created dataplane_manager to handle all cloud calls made during the deployment workflow.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sameerzuberi sameerzuberi force-pushed the deployment-refactor branch 3 times, most recently from 78dcef5 to d5061c4 Compare January 2, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant