Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: aws_caller_identity and aws_partition allocated, even if var.create is false #19

Closed
joaocc opened this issue Sep 23, 2023 · 0 comments · Fixed by #21
Closed

fix: aws_caller_identity and aws_partition allocated, even if var.create is false #19

joaocc opened this issue Sep 23, 2023 · 0 comments · Fixed by #21

Comments

@joaocc
Copy link

joaocc commented Sep 23, 2023

Description

This is to provide a simple fix to aws-ia/terraform-aws-eks-blueprints-addons#261 by avoiding allocating 2 data resources for each instantiation of this module, even when var.create is set to false.
Currently, on aws-ia/terraform-aws-eks-blueprints-addon 72 data elements are instantiated (26x2) even when the module is disabled.

  • [X ] ✋ I have searched the open/closed issues and my issue is not listed.

Versions

  • Module version [Required]: 1.1.x

Reproduction Code [Required]

module "test_empty" {
  source  = "aws-ia/eks-blueprints-addon/aws"
  version = "1.1.0"
  create = false
}

Expected behavior

"aws_caller_identity" and "aws_partition" only instantiated even if var.create is true

Actual behavior

"aws_caller_identity" and "aws_partition" are instantiated even if var.create is false

@joaocc joaocc changed the title aws_caller_identity and aws_partition allocated, even if var.create is false fix: aws_caller_identity and aws_partition allocated, even if var.create is false Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant