refactor: Refactor fargate-fluentbit addon module.
#142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askulkarni2
reviewed
Apr 20, 2023
main.tf
Outdated
| ) | ||
| } | ||
|
|
||
| resource "kubernetes_namespace" "aws_observability" { |
There was a problem hiding this comment.
Suggested change
| resource "kubernetes_namespace" "aws_observability" { | |
| resource "kubernetes_namespace_v1" "aws_observability" { |
main.tf
Outdated
| } | ||
|
|
||
| # fluent-bit-cloudwatch value as the name of the CloudWatch log group that is automatically created as soon as your apps start logging | ||
| resource "kubernetes_config_map" "aws_logging" { |
There was a problem hiding this comment.
Suggested change
| resource "kubernetes_config_map" "aws_logging" { | |
| resource "kubernetes_config_map_v1" "aws_logging" { |
variables.tf
Outdated
| default = false | ||
| } | ||
|
|
||
| variable "fargate_fluentbit_config" { |
There was a problem hiding this comment.
Suggested change
| variable "fargate_fluentbit_config" { | |
| variable "fargate_fluentbit" { |
main.tf
Outdated
Comment on lines
2663
to
2664
| fargate_fluentbit_cwlog_group = "/${var.cluster_name}/fargate-fluentbit-logs" | ||
| fargate_fluentbit_cwlog_stream_prefix = "fargate-logs-" |
There was a problem hiding this comment.
Lets try to be consistent in how we are asking users to provide configuration values for addons. This should look something like...
Suggested change
| fargate_fluentbit_cwlog_group = "/${var.cluster_name}/fargate-fluentbit-logs" | |
| fargate_fluentbit_cwlog_stream_prefix = "fargate-logs-" | |
| ffargate_fluentbit_cwlog_group = try(fargate_fluentbit.cwlog_group, "/${var.cluster_name}/fargate-fluentbit-logs") | |
| fargate_fluentbit_cwlog_stream_prefix = try(fargate_fluentbit.cwlog_stream_prefix "fargate-logs-") |
bryantbiggs
reviewed
Apr 21, 2023
bryantbiggs
reviewed
Apr 21, 2023
askulkarni2
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
fargate-fluentbitaddon.More
pre-commit run -awith this PRFor Moderators
Additional Notes
terraform-aws-eks-blueprints-addons git:(refactor/fargate-fluentbit) ✗ pre-commit run -a trim trailing whitespace.................................................Passed fix end of files.........................................................Passed check for merge conflicts................................................Passed detect private key.......................................................Passed detect aws credentials...................................................Passed Terraform fmt............................................................Passed Terraform docs...........................................................Passed Terraform validate with tflint...........................................Passed Terraform validate.......................................................Passed Terraform validate with tfsec............................................PassedAdditional notes
Not sure if this is the best way to refactor this module, since it does not use Helm charts. Feedbacks are welcome!