Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Velero serviceAccount IRSA configuration and resouces Policy #147

Merged
merged 25 commits into from
Apr 27, 2023

Conversation

rodrigobersa
Copy link
Contributor

What does this PR do?

Velero serviceAccount configuration, differs from the other add-ons. The current setup is not creating the annotations in the velero-server serviceAccount.

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I ran pre-commit run -a with this PR

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

Tested backup execution.

# velero backup-location get 
NAME      PROVIDER   BUCKET/PREFIX                    PHASE       LAST VALIDATED                  ACCESS MODE   DEFAULT
default   aws        bersr-test-velero-20230105/dev   Available   2023-04-27 19:01:38 -0400 EDT   ReadWrite     true
# velero backup create default --include-namespaces default 
Backup request "default" submitted successfully.
Run `velero backup describe default` or `velero backup logs default` for more details.
# velero backup logs default                               
Logs for backup "default" are not available until it's finished processing. Please wait until the backup has a phase of Completed or Failed and try again.
# velero backup logs default
time="2023-04-27T23:02:11Z" level=info msg="Setting up backup temp file" backup=velero/default logSource="pkg/controller/backup_controller.go:613"
time="2023-04-27T23:02:11Z" level=info msg="Setting up plugin manager" backup=velero/default logSource="pkg/controller/backup_controller.go:620"
time="2023-04-27T23:02:11Z" level=info msg="Getting backup item actions" backup=velero/default logSource="pkg/controller/backup_controller.go:624"
time="2023-04-27T23:02:11Z" level=info msg="Setting up backup store to check for backup existence" backup=velero/default logSource="pkg/controller/backup_controller.go:634"
time="2023-04-27T23:02:12Z" level=info msg="Writing backup version file" backup=velero/default 
...
time="2023-04-27T23:02:23Z" level=info msg="Backed up 11 items out of an estimated total of 11 (estimate will change throughout the backup)" backup=velero/default logSource="pkg/backup/backup.go:388" name=kubernetes namespace=default progress= resource=endpointslices.discovery.k8s.io
time="2023-04-27T23:02:23Z" level=info msg="Backed up a total of 11 items" backup=velero/default logSource="pkg/backup/backup.go:413" progress=

@rodrigobersa rodrigobersa requested a review from a team as a code owner April 27, 2023 23:32
@rodrigobersa rodrigobersa merged commit 934a1ea into main Apr 27, 2023
@rodrigobersa rodrigobersa deleted the refactor/velero branch April 27, 2023 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants