Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump add-on versions #159

Merged
merged 3 commits into from
May 24, 2023
Merged

chore: Bump add-on versions #159

merged 3 commits into from
May 24, 2023

Conversation

askulkarni2
Copy link
Contributor

What does this PR do?

Bumps some add-on versions and add update default behavior of VPA to run the admission controller without which it is pretty much useless.

Moved EKS addons to EKS module to use cluster_addons, this makes terraform destroy of addons module less buggy.

Motivation

  • Resolves #

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I ran pre-commit run -a with this PR

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@askulkarni2 askulkarni2 requested a review from a team as a code owner May 24, 2023 21:29
tests/complete/main.tf Outdated Show resolved Hide resolved
Copy link
Contributor

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small nit (was there previously) - otherwise looks great!

@askulkarni2 askulkarni2 merged commit e25b5b1 into main May 24, 2023
@askulkarni2 askulkarni2 deleted the chore/bump-addons branch May 24, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants