chore: Add readme for cluster-proportional-autoscaler installation #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allamand
reviewed
Jun 1, 2023
| @@ -0,0 +1,121 @@ | |||
| # Horizontal cluster-proportional-autoscaler container | |||
|
|
|||
| Horizontal cluster-proportional-autoscaler watches over the number of schedulable nodes and cores of the cluster and resizes the number of replicas for the required resource. This functionality may be desirable for applications that need to be autoscaled with the size of the cluster, such as CoreDNS and other services that scale with the number of nodes/pods in the cluster. | |||
There was a problem hiding this comment.
Maybe add a comment on when this will be useful for CoreDNS ? from which number of nodes we need this addon ?
There was a problem hiding this comment.
To add such recommendations, we need to do testing and gather data. I added a link to the eks best practices guide for this.
bryantbiggs
reviewed
Jun 2, 2023
bryantbiggs
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a readme for installing
cluster-proportional-autoscaler. This readme is based on https://github.com/aws-ia/terraform-aws-eks-blueprints/blob/main/docs/add-ons/cluster-proportional-autoscaler.md with indentations fixed, validation and testing sections added.Motivation
CPA helm chart requires additional values to be passed to be installed. In addition, manual test to observe a scaling event is useful.
More
pre-commit run -awith this PRFor Moderators
Additional Notes