docs: Add helm-release document to explain the different options available #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryantbiggs
reviewed
Jun 7, 2023
bryantbiggs
reviewed
Jun 7, 2023
bryantbiggs
reviewed
Jun 7, 2023
bryantbiggs
reviewed
Jun 7, 2023
bryantbiggs
reviewed
Jun 7, 2023
bryantbiggs
reviewed
Jun 7, 2023
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
bryantbiggs
reviewed
Jun 7, 2023
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
bryantbiggs
reviewed
Jun 7, 2023
docs/helm-release.md
Outdated
| terraform destroy -target=module.addons | ||
| ``` | ||
|
|
||
| ## With EKS Blueprints Add-on Module |
There was a problem hiding this comment.
I struggle a ton on this one, and doesn't need to be solved here, but we should aim to be consistent - either addon/addons or add-on/add-ons
There was a problem hiding this comment.
Searching docs for other projects they use "Add-on" not "addon" when writing in sentences, titles, etc.. (ie Human readable)
bryantbiggs
reviewed
Jun 7, 2023
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
bryantbiggs
reviewed
Jun 7, 2023
bryantbiggs
approved these changes
Jun 7, 2023
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.
Motivation
More
pre-commit run -awith this PRFor Moderators
Additional Notes