Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add helm-release document to explain the different options available #184

Merged
merged 13 commits into from
Jun 7, 2023

Conversation

askulkarni2
Copy link
Contributor

What does this PR do?

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

Motivation

  • Resolves #

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I ran pre-commit run -a with this PR

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@askulkarni2 askulkarni2 marked this pull request as ready for review June 7, 2023 22:02
@askulkarni2 askulkarni2 requested a review from a team as a code owner June 7, 2023 22:02
docs/helm-release.md Outdated Show resolved Hide resolved
docs/helm-release.md Outdated Show resolved Hide resolved
docs/helm-release.md Outdated Show resolved Hide resolved
docs/helm-release.md Outdated Show resolved Hide resolved
docs/helm-release.md Outdated Show resolved Hide resolved
docs/helm-release.md Outdated Show resolved Hide resolved
askulkarni2 and others added 6 commits June 7, 2023 16:06
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
docs/helm-release.md Outdated Show resolved Hide resolved
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
terraform destroy -target=module.addons
```

## With EKS Blueprints Add-on Module
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I struggle a ton on this one, and doesn't need to be solved here, but we should aim to be consistent - either addon/addons or add-on/add-ons

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Searching docs for other projects they use "Add-on" not "addon" when writing in sentences, titles, etc.. (ie Human readable)

docs/helm-release.md Outdated Show resolved Hide resolved
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
docs/helm-release.md Outdated Show resolved Hide resolved
askulkarni2 and others added 2 commits June 7, 2023 16:13
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
@askulkarni2 askulkarni2 merged commit c5f5161 into main Jun 7, 2023
@askulkarni2 askulkarni2 deleted the docs/add-helm-release branch June 7, 2023 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants