Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Bump aws_load_balancer_controller version #190

Closed
wants to merge 1 commit into from

Conversation

armujahid
Copy link

@armujahid armujahid commented Jun 21, 2023

What does this PR do?

updates aws_load_balancer_controller version to latest available version from https://artifacthub.io/packages/helm/aws/aws-load-balancer-controller

Motivation

I was using v4.32.1 blueprints and found that this add-on was outdated in v4 and doesn't work with v1.25 if EndpointSlices are used (https://docs.aws.amazon.com/eks/latest/userguide/kubernetes-versions.html#kubernetes-1.25). I updated it locally using

  enable_aws_load_balancer_controller = true
  aws_load_balancer_controller_helm_config = {
    version = "1.5.3"
  }

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I ran pre-commit run -a with this PR

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

Note that I have tested this with v4.32.1. But I think this should also work with v5 without any change.

@armujahid armujahid requested a review from a team as a code owner June 21, 2023 07:24
@FernandoMiguel
Copy link

sadly the v2.5 requires breaking changes and CRDs to be updated
https://github.com/kubernetes-sigs/aws-load-balancer-controller/releases/tag/v2.5.0

anyone pulling this module, and using this version would end up in a bad state.
this change would require this module to also be a breaking change and clear docs announcement.

@armujahid
Copy link
Author

@FernandoMiguel, thanks for the heads-up. v4.32.1 had aws load balancer chart version 1.4.5 (app version v2.4.4), which was problematic. This repo already has aws load balancer chart 1.4.8 (app version v2.4.7), which should work with v1.25+. For now, I think this PR can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants