Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use the local.region value to setup FluentBit #204 #205

Merged
merged 3 commits into from
Jul 12, 2023

Conversation

chrismld
Copy link
Contributor

What does this PR do?

I added the set of variables that the FluentBit chart uses to override the hard coded value of us-east-1 to the one the Terraform project might be using. Otherwise, the configuration might be pointing to the wrong region and logs won't be pushed correctly.

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I ran pre-commit run -a with this PR

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@chrismld chrismld requested a review from a team as a code owner July 12, 2023 11:15
@chrismld chrismld changed the title Use the local.region value to setup FluentBit #204 fix: use the local.region value to setup FluentBit #204 Jul 12, 2023
@chrismld chrismld changed the title fix: use the local.region value to setup FluentBit #204 fix: Use the local.region value to setup FluentBit #204 Jul 12, 2023
main.tf Outdated
name = "cloudWatchLogs.region"
value = local.region
},
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be open to setting CloudWatch values here, but the others are valid for cross-region log shipping and should be left to users

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bryantbiggs bryantbiggs merged commit de82957 into aws-ia:main Jul 12, 2023
@chrismld chrismld deleted the issue-204 branch July 12, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Region for aws_for_fluentbit is hard coded
2 participants