fix: Use the local.region value to setup FluentBit #204 #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrismld
changed the title
chrismld
changed the title
bryantbiggs
reviewed
Jul 12, 2023
main.tf
Outdated
| name = "cloudWatchLogs.region" | ||
| value = local.region | ||
| }, | ||
| { |
There was a problem hiding this comment.
I would be open to setting CloudWatch values here, but the others are valid for cross-region log shipping and should be left to users
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I added the set of variables that the FluentBit chart uses to override the hard coded value of
us-east-1to the one the Terraform project might be using. Otherwise, the configuration might be pointing to the wrong region and logs won't be pushed correctly.Motivation
aws_for_fluentbitis hard coded #204More
pre-commit run -awith this PRFor Moderators
Additional Notes