Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Set helm_releases default value for wait to false #206

Merged
merged 2 commits into from
Jul 12, 2023
Merged

fix: Set helm_releases default value for wait to false #206

merged 2 commits into from
Jul 12, 2023

Conversation

bryantbiggs
Copy link
Contributor

What does this PR do?

  • Set helm_releases default value for wait to false

Motivation

  • This is what we have for the other addons defined here so that we can avoid Terraform timeout errors and instead let the kubernetes controllers/operators resolve the deployment (eventually)

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I ran pre-commit run -a with this PR

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@bryantbiggs bryantbiggs requested a review from a team as a code owner July 12, 2023 12:00
@askulkarni2 askulkarni2 merged commit c8281a1 into main Jul 12, 2023
5 checks passed
@askulkarni2 askulkarni2 deleted the fix/helm-releases-defaults branch July 12, 2023 14:10
@james-masson james-masson mentioned this pull request Oct 3, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@askulkarni2 askulkarni2 askulkarni2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bryantbiggs @askulkarni2