Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for gitops-bridge #209

Merged
merged 15 commits into from
Aug 17, 2023

Conversation

csantanapr
Copy link
Contributor

@csantanapr csantanapr commented Jul 21, 2023

What does this PR do?

Adds the ability to skip the use of terraform helm and kubernetes providers via new variable create_kubernetes_resources

Adds a new output gitops_metadata this output will have the aws metadata from the aws resources created in terraform, this metadata is to be use with a gitops engine such as ArgoCD or FluxCD to pass this metadata over a gitops-bridge.

To see example how this output is used checkout the gitops-bridge terraform/examples/eks/

Motivation

Resolves #114

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I ran pre-commit run -a with this PR

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@csantanapr csantanapr changed the title implement gitops-bridge-v2 Add support for gitops-bridge Jul 21, 2023
@csantanapr csantanapr changed the title Add support for gitops-bridge feat: Add support for gitops-bridge Jul 21, 2023
@csantanapr csantanapr marked this pull request as ready for review August 2, 2023 12:38
@csantanapr csantanapr requested a review from a team as a code owner August 2, 2023 12:38
variables.tf Outdated Show resolved Hide resolved
@csantanapr
Copy link
Contributor Author

@bryantbiggs I updated the PR to address the feedback, please take another look when you have chance

outputs.tf Outdated Show resolved Hide resolved
outputs.tf Outdated Show resolved Hide resolved
outputs.tf Outdated Show resolved Hide resolved
outputs.tf Outdated Show resolved Hide resolved
outputs.tf Outdated Show resolved Hide resolved
Signed-off-by: Carlos Santana <csantana23@gmail.com>
Signed-off-by: Carlos Santana <csantana23@gmail.com>
Signed-off-by: Carlos Santana <csantana23@gmail.com>
Signed-off-by: Carlos Santana <csantana23@gmail.com>
Signed-off-by: Carlos Santana <csantana23@gmail.com>
Signed-off-by: Carlos Santana <csantana23@gmail.com>
Signed-off-by: Carlos Santana <csantana23@gmail.com>
Signed-off-by: Carlos Santana <csantana23@gmail.com>
Signed-off-by: Carlos Santana <csantana23@gmail.com>
Signed-off-by: Carlos Santana <csantana23@gmail.com>
Signed-off-by: Carlos Santana <csantana23@gmail.com>
Signed-off-by: Carlos Santana <csantana23@gmail.com>
Signed-off-by: Carlos Santana <csantana23@gmail.com>
Signed-off-by: Carlos Santana <csantana23@gmail.com>
Signed-off-by: Carlos Santana <csantana23@gmail.com>
@csantanapr
Copy link
Contributor Author

csantanapr commented Aug 17, 2023

Hi @bryantbiggs I made the updates based on your feedback please another look when you have a chance

Copy link
Contributor

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets do it!

@bryantbiggs bryantbiggs merged commit a780ef3 into aws-ia:main Aug 17, 2023
5 checks passed
@csantanapr
Copy link
Contributor Author

@bryantbiggs and thank you for the review and merging 🍾

@bryantbiggs
Copy link
Contributor

Thank you! Now let's get folks to quit sending Terraform into the cluster!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improved integration between Terraform and GitOps providers
2 participants