-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for gitops-bridge #209
Conversation
f9bd1ef
to
eb10702
Compare
cd3f855
to
6f67e98
Compare
@bryantbiggs I updated the PR to address the feedback, please take another look when you have chance |
Signed-off-by: Carlos Santana <csantana23@gmail.com>
Signed-off-by: Carlos Santana <csantana23@gmail.com>
Signed-off-by: Carlos Santana <csantana23@gmail.com>
Signed-off-by: Carlos Santana <csantana23@gmail.com>
Signed-off-by: Carlos Santana <csantana23@gmail.com>
Signed-off-by: Carlos Santana <csantana23@gmail.com>
Signed-off-by: Carlos Santana <csantana23@gmail.com>
Signed-off-by: Carlos Santana <csantana23@gmail.com>
Signed-off-by: Carlos Santana <csantana23@gmail.com>
Signed-off-by: Carlos Santana <csantana23@gmail.com>
Signed-off-by: Carlos Santana <csantana23@gmail.com>
Signed-off-by: Carlos Santana <csantana23@gmail.com>
Signed-off-by: Carlos Santana <csantana23@gmail.com>
Signed-off-by: Carlos Santana <csantana23@gmail.com>
3a07eb5
to
3653753
Compare
Hi @bryantbiggs I made the updates based on your feedback please another look when you have a chance
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets do it!
@bryantbiggs and thank you for the review and merging 🍾 |
Thank you! Now let's get folks to quit sending Terraform into the cluster!!! |
What does this PR do?
Adds the ability to skip the use of terraform helm and kubernetes providers via new variable
create_kubernetes_resources
Adds a new output
gitops_metadata
this output will have the aws metadata from the aws resources created in terraform, this metadata is to be use with a gitops engine such as ArgoCD or FluxCD to pass this metadata over a gitops-bridge.To see example how this output is used checkout the gitops-bridge terraform/examples/eks/
Motivation
Resolves #114
More
pre-commit run -a
with this PRFor Moderators
Additional Notes