Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add argo events addon module #210

Merged
merged 2 commits into from
Jul 24, 2023
Merged

Conversation

ovaleanu
Copy link
Contributor

What does this PR do?

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I ran pre-commit run -a with this PR

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@ovaleanu ovaleanu requested a review from a team as a code owner July 21, 2023 15:51
@csantanapr
Copy link
Contributor

csantanapr commented Jul 21, 2023

We are not accepting more generic helm charts that do not require any aws metadata, we added a variable helm_releases you can pass as many helm charts you want as a map take a look at the example here https://github.com/aws-ia/terraform-aws-eks-blueprints-addons/blob/main/tests/complete/main.tf#L189C3-L219

This allows the user to specify an infinity number of helm charts, or they can use the normal terraform helm provider them selfs outside the eks blueprints addons module. the module doesn't add any value to these charts

@bryantbiggs bryantbiggs merged commit c4c821c into aws-ia:main Jul 24, 2023
5 checks passed
@askulkarni2 askulkarni2 mentioned this pull request Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants