Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: FluenBit add-on CW Log group fix #228

Merged
merged 2 commits into from
Aug 11, 2023
Merged

fix: FluenBit add-on CW Log group fix #228

merged 2 commits into from
Aug 11, 2023

Conversation

vara-bonthu
Copy link
Contributor

@vara-bonthu vara-bonthu commented Aug 11, 2023

What does this PR do?

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

Motivation

  • FluentBit Helm Chart is trying to create a new CW Log Group by default with name /aws/eks/fluentbit-cloudwatch/logs. We are disabling that using set values. Users can enable but its not advisable as this module not configuring the IRSA policies for this log group
  • This add-on module provides a better approach for setting up a CloudWatch Log Group for FluentBit while ensuring proper IRSA policies. Users can provide their Log group name, or the module will set it as /${var.cluster_name}/aws-fluentbit-logs if not specified.
  • Adds a fix to IAM policy to ensure log stream can be queried without any errors

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I ran pre-commit run -a with this PR

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@vara-bonthu vara-bonthu requested a review from a team as a code owner August 11, 2023 13:20
Copy link
Contributor

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@vara-bonthu vara-bonthu merged commit 1f4b8c4 into main Aug 11, 2023
@vara-bonthu vara-bonthu deleted the fix-fluentbit branch August 11, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FluentBit Helm add-on throws multiple errors
2 participants