feat: Add route53:listtagsforresource to external-dns
#256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to have access to the tags on the Route 53 zone.
blakepettersson
changed the title
bryantbiggs
changed the title
route53:listtagsforresource to external-dns
bryantbiggs
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to have access to the tags on the Route 53 zone.
What does this PR do?
The addition of
route53:ListTagsForResourceto the external-dns IAM policy.Motivation
After having a chat with @csantanapr who informed me of this project I decided to take this project for a spin. There are a few things missing from this project preventing us from using this, this issue being one of them.
More
pre-commit run -awith this PRFor Moderators
Additional Notes