Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Correct Helm chart repository and version of "kube-prometheus-stack" example reference #265

Merged
merged 1 commit into from
Sep 26, 2023
Merged

docs: Correct Helm chart repository and version of "kube-prometheus-stack" example reference #265

merged 1 commit into from
Sep 26, 2023

Conversation

pedrodsrodrigues
Copy link
Contributor

Motivation

  • People interested in trying this add-on will be confused as to why it doesn't work. Since I have noticed it and had that problem, why not help the community with such a simple fix?

@pedrodsrodrigues pedrodsrodrigues requested a review from a team as a code owner September 26, 2023 12:52
@bryantbiggs bryantbiggs changed the title fix: Change repository helm chart and version of "kube-prometheus-stack" docs: Correct Helm chart repository and version of "kube-prometheus-stack" example reference Sep 26, 2023
Copy link
Contributor

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you - do note that this is just documentation that is being corrected. The actual implementation has the correct repository listed so there shouldn't be any errors

repository = try(var.kube_prometheus_stack.repository, "https://prometheus-community.github.io/helm-charts")

@bryantbiggs bryantbiggs merged commit a555f06 into aws-ia:main Sep 26, 2023
@pedrodsrodrigues pedrodsrodrigues deleted the fix/kube-prometheus-stack branch September 26, 2023 13:31
williamsbobby1423 pushed a commit to williamsbobby1423/terraform-aws-eks-blueprints-addons that referenced this pull request Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants