Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Grant IAM policy permissions to allow Fargate Fluent Bit to send logs to Kinesis Data Firehose #310

Merged
merged 8 commits into from
Dec 7, 2023
Merged

feat: Grant IAM policy permissions to allow Fargate Fluent Bit to send logs to Kinesis Data Firehose #310

merged 8 commits into from
Dec 7, 2023

Conversation

vilakshan2996
Copy link
Contributor

@vilakshan2996 vilakshan2996 commented Nov 12, 2023 •
edited
Loading

What does this PR do?

This pull request enables users to grant IAM policy permissions to allow Fargate Fluent Bit to send logs to Kinesis Data Firehose

Motivation

I have encountered this issue. My company requires me to send logs to Kinesis Data Firehose, and I implemented this solution through the aforementioned modification. - Resolves #118

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I ran pre-commit run -a with this PR

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@vilakshan2996 vilakshan2996 requested a review from a team as a code owner November 12, 2023 07:20
@vilakshan2996 vilakshan2996 changed the title Grant IAM policy permissions to allow Fargate Fluent Bit to send logs to Kinesis Data Firehose feat:Grant IAM policy permissions to allow Fargate Fluent Bit to send logs to Kinesis Data Firehose Nov 12, 2023
@vilakshan2996 vilakshan2996 changed the title feat:Grant IAM policy permissions to allow Fargate Fluent Bit to send logs to Kinesis Data Firehose feat: Grant IAM policy permissions to allow Fargate Fluent Bit to send logs to Kinesis Data Firehose Nov 12, 2023
bryantbiggs
bryantbiggs reviewed Nov 15, 2023
View reviewed changes
main.tf Outdated Show resolved Hide resolved
bryantbiggs
bryantbiggs reviewed Nov 15, 2023
View reviewed changes
main.tf Outdated Show resolved Hide resolved
bryantbiggs
bryantbiggs reviewed Nov 15, 2023
View reviewed changes
main.tf Outdated Show resolved Hide resolved
vilakshan2996 and others added 3 commits November 16, 2023 07:36
@vilakshan2996 @bryantbiggs
Update main.tf
a715cd0 
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
@vilakshan2996 @bryantbiggs
Update main.tf
59f4899 
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
@vilakshan2996
Merge branch 'main' into main
277bb92
rodrigobersa
rodrigobersa requested changes Nov 21, 2023
View reviewed changes
main.tf Outdated Show resolved Hide resolved
rodrigobersa
rodrigobersa approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@rodrigobersa rodrigobersa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vilakshan2996 !!

@rodrigobersa rodrigobersa merged commit 99520ae into aws-ia:main Dec 7, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryantbiggs bryantbiggs bryantbiggs left review comments

@rodrigobersa rodrigobersa rodrigobersa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

enhancement: Add support to send Fluentbit logs to multiple destinations.
3 participants
@vilakshan2996 @bryantbiggs @rodrigobersa