Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Restrict Karpenter privileges on AWS SSM parameter store #319

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

CCOLLOT
Copy link
Contributor

@CCOLLOT CCOLLOT commented Nov 21, 2023

What does this PR do?

The Karpenter documentation references less privileges (AWS SSM Parameter Store read access) than what's implemented in the current addon module for karpenter.

This PR reconciles the current terraform module with what the documentation states.

Motivation

Follow the principle of least privilege

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I ran pre-commit run -a with this PR

For Moderators

  • E2E Test successfully complete before merge?

The Karpenter documentation (https://karpenter.sh/docs/reference/cloudformation/#:~:text=Copy-,AllowSSMReadActions,-The%20AllowSSMReadActions%20Sid) references less privileges than what's implemented in the current addon module for karpenter
@CCOLLOT CCOLLOT requested a review from a team as a code owner November 21, 2023 10:40
@CCOLLOT CCOLLOT changed the title restrict Karpenter privileges on AWS SSM parameter store fix: restrict Karpenter privileges on AWS SSM parameter store Nov 21, 2023
@CCOLLOT CCOLLOT changed the title fix: restrict Karpenter privileges on AWS SSM parameter store fix: Restrict Karpenter privileges on AWS SSM parameter store Nov 21, 2023
Copy link
Contributor

@rodrigobersa rodrigobersa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @CCOLLOT!

Thanks for bringing this up.

@rodrigobersa rodrigobersa merged commit 0e9d6c9 into aws-ia:main Nov 21, 2023
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants