Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Typo on termination handler #322

Merged
merged 1 commit into from
Nov 29, 2023
Merged

fix: Typo on termination handler #322

merged 1 commit into from
Nov 29, 2023

Conversation

emoreth
Copy link

@emoreth emoreth commented Nov 28, 2023

ASGTerminiate -> ASGTerminate

What does this PR do?

Fix typo

Motivation

/NA

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I ran pre-commit run -a with this PR

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

/NA

@emoreth
Typo on termination handler
8815292 
ASGTerminiate -> ASGTerminate
@emoreth emoreth requested a review from a team as a code owner November 28, 2023 17:37
@emoreth emoreth changed the title Typo on termination handler fix: Typo on termination handler Nov 28, 2023
@bryantbiggs bryantbiggs added this to the v2.0 milestone Nov 28, 2023
@bryantbiggs
Copy link
Contributor

Thank you! Since this will cause resource re-creation we will include it in v2.0

@bryantbiggs bryantbiggs changed the base branch from main to v2.0 November 29, 2023 17:31
@bryantbiggs bryantbiggs changed the base branch from v2.0 to main November 29, 2023 17:34
@bryantbiggs bryantbiggs changed the base branch from main to v2.0 November 29, 2023 17:34
bryantbiggs
bryantbiggs approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! Going into the v2 branch!

@bryantbiggs bryantbiggs merged commit bb92a10 into aws-ia:v2.0 Nov 29, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryantbiggs bryantbiggs bryantbiggs approved these changes

Assignees
No one assigned
Labels
BREAKING CHANGE
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@emoreth @bryantbiggs