fix: Add karpenter iam policy sids #324
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is so that we can use `source_policy_documents` or `override_policy_documents`.
blakepettersson
changed the title
|
This PR has been automatically marked as stale because it has been open 30 days |
|
Still relevant IMO |
csantanapr
reviewed
Feb 1, 2024
|
This PR has been automatically marked as stale because it has been open 30 days |
|
Pull request closed due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is so that
source_policy_documentsoroverride_policy_documentscan be used without appending new policies to the generated Karpenter policy document. If we can specify a sid, we can override the specific sid with the policy which we need.Motivation
In our environment we needed to modify
ec2:CreateFleetto be a bit less restrictive, since the default policy only allows for modifications of resources within the same account. Since we have a setup where subnets are shared from another account, we need to modify that policy.More
pre-commit run -awith this PRFor Moderators
Additional Notes