Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Adding support for the default namespace service account to access AWS Secret Manager #338

Closed
wants to merge 1 commit into from
Closed

fix: Adding support for the default namespace service account to access AWS Secret Manager #338

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2325,6 +2325,7 @@ module "external_dns" {
locals {
external_secrets_service_account = try(var.external_secrets.service_account_name, "external-secrets-sa")
external_secrets_namespace = try(var.external_secrets.namespace, "external-secrets")
external_secrets_service_account_namespace = try(var.external_secrets.service_account_namespace, "external-secrets")
}

data "aws_iam_policy_document" "external_secrets" {
Expand Down Expand Up @@ -2462,7 +2463,7 @@ module "external_secrets" {
oidc_providers = {
this = {
provider_arn = local.oidc_provider_arn
# namespace is inherited from chart
namespace = local.external_secrets_service_account_namespace
service_account = local.external_secrets_service_account
}
}
Expand Down
Loading