Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change Karpenter instance termination key condition to use more broadly applciable #346

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

bryantbiggs
Copy link
Contributor

What does this PR do?

  • Change Karpenter instance termination key condition to use more broadly applciable

Motivation

  • On later versions of karpenter (0.32+), the nodes are named by karpenter which can create conflicts with the current policy. Previous attempts to add additional name pattern globs as well as let users pass in both key and values to suite are still creating friction. Using this tag, which has been around since pre 0.10 Karpenter, should remove that friction for user until the policy defined here is updated to match the upstream project

  • Resolves fix indentation in karpenter pause deployment docs #336

  • Resolves karpenter cannot delete nodes it creates in GovCloud #339

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I ran pre-commit run -a with this PR

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@bryantbiggs bryantbiggs requested a review from a team as a code owner January 23, 2024 22:55
Copy link

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bryantbiggs bryantbiggs merged commit a408617 into main Jan 24, 2024
6 checks passed
@bryantbiggs bryantbiggs deleted the fix/karpenter-again branch January 24, 2024 13:13
@vstthomas
Copy link

@bryantbiggs, how would we test this out? specify a newer version of the blueprints-addons or some other method?

@bryantbiggs
Copy link
Contributor Author

at minimum, you would want to upgrade to v1.13.0 of this addons module to utilize this fix

If you want to test it, you could change the Karpenter Helm chart version to something pre-v1beta1 APIs and check that Karpenter can create/destroy nodes with this version. Then change to the latest Karpenter version and do the same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

karpenter cannot delete nodes it creates in GovCloud fix indentation in karpenter pause deployment docs
4 participants