fix: Change Karpenter instance termination key condition to use more broadly applciable #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bryantbiggs, how would we test this out? specify a newer version of the blueprints-addons or some other method? |
|
at minimum, you would want to upgrade to If you want to test it, you could change the Karpenter Helm chart version to something pre-v1beta1 APIs and check that Karpenter can create/destroy nodes with this version. Then change to the latest Karpenter version and do the same |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
On later versions of karpenter (0.32+), the nodes are named by karpenter which can create conflicts with the current policy. Previous attempts to add additional name pattern globs as well as let users pass in both key and values to suite are still creating friction. Using this tag, which has been around since pre 0.10 Karpenter, should remove that friction for user until the policy defined here is updated to match the upstream project
Resolves fix indentation in karpenter pause deployment docs #336
Resolves karpenter cannot delete nodes it creates in GovCloud #339
More
pre-commit run -awith this PRFor Moderators
Additional Notes