Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(karpenter): Pin to previous working chart version #366

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -3015,7 +3015,7 @@ module "karpenter" {
namespace = local.karpenter_namespace
create_namespace = try(var.karpenter.create_namespace, true)
chart = try(var.karpenter.chart, "karpenter")
chart_version = try(var.karpenter.chart_version, "0.35.0")
chart_version = try(var.karpenter.chart_version, "v0.32.1")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the downgrade?
v0.35.1 is out

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this issue still exists and needs fixing aws/karpenter-provider-aws#5415

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A workaround could be pinning the image tag to the correct one instead perhaps but I haven't tested that

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, but I am unable to reproduce the error - the default version is just that, a default. we encourage users to specify the version in order to have better control over which version is used and when that changes. for now, I would say set the v0.32.1 version in your configuration if that what puts things back into a healthy state. Closing this out for now though

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting you couldn't reproduce with the default values. Did you test this with an upgrade or in a fresh install?

I'm happy for it to be closed if no one else is seeing the issue, perhaps it's related to our deployment but we're installing karpenter with mostly default values including the image and helm chart

repository = try(var.karpenter.repository, "oci://public.ecr.aws/karpenter")
values = try(var.karpenter.values, [])

Expand Down