Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: When use aws_for_fluentbit disable create cloudwatch log group, will let fluentbit config setting LogGroupName to "" #408 #409

Conversation

neilkuan
Copy link

@neilkuan neilkuan commented Aug 22, 2024

What does this PR do?

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I ran pre-commit run -a with this PR

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@neilkuan neilkuan requested a review from a team as a code owner August 22, 2024 07:00
@neilkuan
Copy link
Author

After fix that.

image

The config will have good format.

image

@neilkuan
Copy link
Author

image

@neilkuan neilkuan changed the title fix: do want aws_for_fluentbit module create cloudwatch log group fix: do not aws_for_fluentbit module create cloudwatch log group Aug 22, 2024
@neilkuan neilkuan changed the title fix: do not aws_for_fluentbit module create cloudwatch log group Fix: do not aws_for_fluentbit module create cloudwatch log group Aug 22, 2024
@neilkuan neilkuan changed the title Fix: do not aws_for_fluentbit module create cloudwatch log group Fix: When use aws_for_fluentbit disable create cloudwatch log group, will let fluentbit config setting LogGroupName to "" #408 Aug 22, 2024
@neilkuan neilkuan changed the title Fix: When use aws_for_fluentbit disable create cloudwatch log group, will let fluentbit config setting LogGroupName to "" #408 fix: When use aws_for_fluentbit disable create cloudwatch log group, will let fluentbit config setting LogGroupName to "" #408 Aug 22, 2024
@neilkuan neilkuan closed this Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant