Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Enable external-secrets support via GitOps and ArgoCD #1049

Merged
merged 1 commit into from
Oct 13, 2022
Merged

fix: Enable external-secrets support via GitOps and ArgoCD #1049

merged 1 commit into from
Oct 13, 2022

Conversation

kahirokunn
Copy link
Contributor

@kahirokunn kahirokunn commented Oct 13, 2022 •
edited
Loading

What does this PR do?

external secrets are now available in git ops.

Motivation

without it, git ops will not install external secrets.

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs require a new example and/or doc page. In general:

  • Use an existing example when possible to demonstrate a new addons usage
  • A new docs page under docs/add-ons/* is required for new a new addon

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@kahirokunn kahirokunn temporarily deployed to EKS Blueprints Test October 13, 2022 08:26 Inactive
@bryantbiggs bryantbiggs changed the title chore: enable external secrets fix: Enable external-secrets support via GitOps and ArgoCD Oct 13, 2022
@kahirokunn kahirokunn temporarily deployed to EKS Blueprints Test October 13, 2022 13:50 Inactive
bryantbiggs
bryantbiggs approved these changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@bryantbiggs bryantbiggs merged commit d115cba into aws-ia:main Oct 13, 2022
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Dec 15, 2022
@kahirokunn @allamand
fix: Enable external-secrets support via GitOps and ArgoCD (aws-ia#…
fd775c9 
…1049)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryantbiggs bryantbiggs bryantbiggs approved these changes

@askulkarni2 askulkarni2 Awaiting requested review from askulkarni2

@kcoleman731 kcoleman731 Awaiting requested review from kcoleman731

@vara-bonthu vara-bonthu Awaiting requested review from vara-bonthu

@Zvikan Zvikan Awaiting requested review from Zvikan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kahirokunn @bryantbiggs