feat: Allow users to specify the Windows Server version; 2019 (default) or 2022
#1078
Conversation
…d-update Feature/windows self managed nd update
IgorEulalio
requested review from
askulkarni2,
csantanapr,
vara-bonthu,
bryantbiggs and
Zvikan
as code owners
IgorEulalio
changed the title
|
Marcio Morales - AWS Windows Container SME, reviewed and worked together with Igor in the proposed solution. |
IgorEulalio
changed the title
| @@ -49,16 +51,20 @@ locals { | |||
| var.self_managed_ng | |||
| ) | |||
|
|
|||
| # WINDOWS CONFIGURATION | |||
| compatible_with_windows_server_2022 = var.context.cluster_version >= "1.22" ? true : false | |||
There was a problem hiding this comment.
- Can users create clusters with 2019 AMI on 1.22/1.23?
- Can users create clusters with 2022 AMI on 1.19-1.22?
Also, this is not a valid comparison var.context.cluster_version >= "1.22", this is not a numerical comparison
I think what we want to do is add a variable for the windows_server_version and have it default to 2019 but users have the ability to pass in 2022 and then we can get rid of the other changes
There was a problem hiding this comment.
We are looking to change the default to 2022 instead of 2019, but do not exist AMI for Windows Server 2022 that are compatible with cluster below 1.22, so the default must be 2022 for all clusters that are in 1.22 or above and 2019 for cluster that are below.
There was a problem hiding this comment.
If users have created clusters with 2019 AMI on 1.22/1.23 clusters, this would be a disruptive change for them and therefore it falls under a breaking change. "
There was a problem hiding this comment.
Is it possible to describe that on the new version disclaimer and make this new version default? This behavior is intentional.
bryantbiggs
changed the title
2019 (default) or 2022
…ult) or `2022` (#1078) Co-authored-by: igor lopes <igoreul@amazon.com> Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
…ult) or `2022` (aws-ia#1078) Co-authored-by: igor lopes <igoreul@amazon.com> Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
…ult) or `2022` (aws-ia#1078) Co-authored-by: igor lopes <igoreul@amazon.com> Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
What does this PR do?
This PR allows clients to override the version of windows server and set the default version to 2022 for clusters in 1.22 or above.
Motivation
Windows Server 2022 is the new and recommend operation system to run Windows containers on Kubernetes. It accommodates all the new features previously only available on Windows Server SAC versions. The AWS Windows container SME team is already helping and spreading the message for customers to start migrating from 2019 to 2022.
With this new addition to EKS Blueprints, customers can leverage the new Windows Server 2022 on EKS clusters version 1.22+ and maintain their Windows Server 2019 on older EKS cluster versions.
More
I used the example that already exists for windows cluster.
pre-commit run -awith this PRNote: Not all the PRs require a new example and/or doc page. In general:
docs/add-ons/*is required for new a new addonFor Moderators
Additional Notes
This is a pontual change to make the default windows server used today more flexible and also push users to use the new version of windows server.