Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for istio-csr addon #1100

Merged
merged 9 commits into from
Oct 31, 2022
Merged

feat: Add support for istio-csr addon #1100

merged 9 commits into from
Oct 31, 2022

Conversation

Pacobart
Copy link
Contributor

What does this PR do?

Adds istio-csr addon. This addon allows istio to use cert-manager for mTLS certificate generation and management.

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs require a new example and/or doc page. In general:

  • Use an existing example when possible to demonstrate a new addons usage
  • A new docs page under docs/add-ons/* is required for new a new addon

For Moderators

  • E2E Test successfully complete before merge?

@Pacobart Pacobart changed the title Feature: adding istio-csr addon feat: Adding istio-csr addon Oct 28, 2022
@Pacobart Pacobart marked this pull request as ready for review October 28, 2022 15:49
@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test October 31, 2022 14:32 Inactive
@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test October 31, 2022 14:37 Inactive
@bryantbiggs bryantbiggs changed the title feat: Adding istio-csr addon feat: Add support for istio-csr addon Oct 31, 2022
@bryantbiggs bryantbiggs merged commit 95795f8 into aws-ia:main Oct 31, 2022
@Pacobart Pacobart deleted the 1055_istio-csr branch October 31, 2022 21:02
vara-bonthu pushed a commit that referenced this pull request Nov 11, 2022
@Pacobart @bryantbiggs @vara-bonthu
feat: Add support for istio-csr addon (#1100)
1eaf3be 
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Dec 15, 2022
@Pacobart @bryantbiggs @allamand
feat: Add support for istio-csr addon (aws-ia#1100)
0b036ff 
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
@deepakjeena
Copy link

@Pacobart : Kindly look into : #1280

allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Jan 10, 2023
@Pacobart @bryantbiggs @allamand
feat: Add support for istio-csr addon (aws-ia#1100)
7962d28 
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryantbiggs bryantbiggs bryantbiggs approved these changes

@askulkarni2 askulkarni2 Awaiting requested review from askulkarni2

@csantanapr csantanapr Awaiting requested review from csantanapr

@vara-bonthu vara-bonthu Awaiting requested review from vara-bonthu

@Zvikan Zvikan Awaiting requested review from Zvikan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add istio-csr addon
3 participants
@Pacobart @deepakjeena @bryantbiggs