Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Guidance for better cleanup process due to orphaned resources #1134

Merged
merged 4 commits into from
Nov 5, 2022

Conversation

Zvikan
Copy link
Contributor

@Zvikan Zvikan commented Nov 4, 2022

What does this PR do?

  • Add guidance how to solve argocd failures due to orphaned applications and resources
  • Add FAQ regards orphaned resources for any examples leading to k8s resources managed by terraform to be destroyed properly
    🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
    Consult the CONTRIBUTING guide for submitting pull-requests.

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs require a new example and/or doc page. In general:

  • Use an existing example when possible to demonstrate a new addons usage
  • A new docs page under docs/add-ons/* is required for new a new addon

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useful doc. Looks good to me 👍🏼

@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test November 5, 2022 21:52 Inactive
@bryantbiggs bryantbiggs merged commit 65c9960 into main Nov 5, 2022
@bryantbiggs bryantbiggs deleted the fix/865-1114-guidance-orphaned-resources branch November 5, 2022 21:55
vara-bonthu pushed a commit that referenced this pull request Nov 11, 2022
…1134)

Co-authored-by: Apoorva Kulkarni <kuapoorv@amazon.com>
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Dec 15, 2022
…ws-ia#1134)

Co-authored-by: Apoorva Kulkarni <kuapoorv@amazon.com>
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Jan 10, 2023
…ws-ia#1134)

Co-authored-by: Apoorva Kulkarni <kuapoorv@amazon.com>
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants