Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add outputs for addons created #1136

Merged
merged 2 commits into from
Nov 5, 2022
Merged

feat: Add outputs for addons created #1136

merged 2 commits into from
Nov 5, 2022

Conversation

bryantbiggs
Copy link
Contributor

What does this PR do?

  • Add outputs for addons created

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs require a new example and/or doc page. In general:

  • Use an existing example when possible to demonstrate a new addons usage
  • A new docs page under docs/add-ons/* is required for new a new addon

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test November 4, 2022 22:16 Inactive
@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test November 5, 2022 00:13 Inactive
@bryantbiggs bryantbiggs marked this pull request as ready for review November 5, 2022 00:14
vara-bonthu
vara-bonthu approved these changes Nov 5, 2022
View reviewed changes
Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@bryantbiggs bryantbiggs merged commit c309d3b into main Nov 5, 2022
@bryantbiggs bryantbiggs deleted the feat/addon-outputs branch November 5, 2022 10:50
vara-bonthu pushed a commit that referenced this pull request Nov 11, 2022
@bryantbiggs @vara-bonthu
feat: Add outputs for addons created (#1136)
3a90963
@bryantbiggs bryantbiggs mentioned this pull request Nov 21, 2022
Closed
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Dec 15, 2022
@bryantbiggs @allamand
feat: Add outputs for addons created (aws-ia#1136)
516b752
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Jan 10, 2023
@bryantbiggs @allamand
feat: Add outputs for addons created (aws-ia#1136)
7858dac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vara-bonthu vara-bonthu vara-bonthu approved these changes

@askulkarni2 askulkarni2 Awaiting requested review from askulkarni2

@csantanapr csantanapr Awaiting requested review from csantanapr

@Zvikan Zvikan Awaiting requested review from Zvikan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE]Access to helm_release in addon outputs
2 participants
@bryantbiggs @vara-bonthu