Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow overriding service-account-name #1193

Merged
merged 2 commits into from
Nov 19, 2022
Merged

feat: Allow overriding service-account-name #1193

merged 2 commits into from
Nov 19, 2022

Conversation

nitrocode
Copy link
Contributor

@nitrocode nitrocode commented Nov 18, 2022 •
edited
Loading

What does this PR do?

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

Motivation

  • Allows overriding IAM roles by changing the service account name per kubernetes-addon

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs require a new example and/or doc page. In general:

  • Use an existing example when possible to demonstrate a new addons usage
  • A new docs page under docs/add-ons/* is required for new a new addon

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

Previous PR #1184

@nitrocode nitrocode force-pushed the override-service-account-name branch from a5f705d to 42d6a56 Compare November 18, 2022 19:43
@nitrocode nitrocode force-pushed the override-service-account-name branch from 42d6a56 to 6ef520e Compare November 18, 2022 19:51
@nitrocode nitrocode requested review from bryantbiggs and removed request for csantanapr, askulkarni2, vara-bonthu and Zvikan November 18, 2022 19:52
@bryantbiggs bryantbiggs force-pushed the override-service-account-name branch from 78d6fcf to 24c823b Compare November 19, 2022 00:28
@bryantbiggs bryantbiggs force-pushed the override-service-account-name branch from 24c823b to 18b538d Compare November 19, 2022 00:34
@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test November 19, 2022 00:34 Inactive
@bryantbiggs bryantbiggs merged commit 4c23429 into aws-ia:main Nov 19, 2022
@bryantbiggs bryantbiggs mentioned this pull request Nov 19, 2022
Closed
1 task
@nitrocode nitrocode deleted the override-service-account-name branch November 19, 2022 01:05
@nitrocode
Copy link
Contributor Author

Thank you!!! Happy Friday!

@nitrocode nitrocode mentioned this pull request Nov 24, 2022
Closed
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Dec 15, 2022
@nitrocode @bryantbiggs @allamand
feat: Allow overriding service-account-name (aws-ia#1193)
39b1fee 
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Jan 10, 2023
@nitrocode @bryantbiggs @allamand
feat: Allow overriding service-account-name (aws-ia#1193)
1dac858 
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryantbiggs bryantbiggs bryantbiggs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nitrocode @bryantbiggs